Fix for relative links#181
Open
jack-fireworkhq wants to merge 4 commits into
Open
Conversation
Add an -L option for passing multi files to Mark.
This reverts commit 549285f.
|
I had the problem with relative links Thanks to all of you for your work and help |
|
@jack-fireworkhq , @kertechs is this PR good to be merged ? |
Author
It works for me and my team. I'd recommend you try it first before merging it |
Contributor
|
I'd be eager to have this feature merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Kovetskiy, First of all, thank you for creating this great repo.
I have done some effort to resolve #55, I think the main cause for this is here which makes Mark failed to find relative links.
I fixed it with code here.
Besides that, I add a "-L" option so that Mark can take many files at the same time as input.
I did that to let users be able to synchronize files references with relative links to each other.
I add a loop here to retry resolve relative links after everything was synchronized to Confluence once.
I tested this with the Github action I forked and modified it, and Mark works as my expectation.
Leave some comments if you feel some code needs to be changed.
PS: This JackTheMico is my personal account, I guess there is a misconfiguration of my git 😄 .